chore: rename subscribe_batch to subscribe_buckets#255
Merged
Conversation
Contributor
Author
|
@fresh-borzoni Please help review it. |
There was a problem hiding this comment.
Pull request overview
This PR renames the method subscribe_batch to subscribe_buckets across the Rust codebase and C++ bindings to avoid confusion with "record batch" terminology. The change improves API clarity by ensuring that "batch" terminology is reserved for record batches rather than collections of bucket subscriptions.
Changes:
- Renamed
subscribe_batchmethod tosubscribe_bucketsin scanner implementation and public APIs - Updated error messages to reflect the new method name
- Updated all call sites in tests, examples, and C++ bindings
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/fluss/tests/integration/log_table.rs | Updated test to use the renamed subscribe_buckets method |
| crates/fluss/src/client/table/scanner.rs | Renamed internal and public subscribe_batch methods to subscribe_buckets in LogScannerInner, LogScanner, and RecordBatchLogScanner, including error message update |
| bindings/cpp/src/table.cpp | Updated C++ binding to call the renamed subscribe_buckets FFI method |
| bindings/cpp/src/lib.rs | Renamed FFI bridge methods from subscribe_batch to subscribe_buckets |
| bindings/cpp/examples/example.cpp | Updated example code error check string to reference subscribe_buckets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fresh-borzoni
approved these changes
Feb 5, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@luoyuxia TY for the PR. LGTM. I'll rename in python bindings as well then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #253
Brief change log
Tests
API and Format
Documentation